You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh I see now what you meant @dryajov. The /dns in the protocol codes table is definitely correct as it is.
@diasdavid the context is that @dryajov noticed that there's /dnsaddr in go-ipfs, but not in js-ipfs, and that there's /dns in js-ipfs but not anywhere else.
I think I'd propose:
Remove /dns -- we haven't defined /dns, the only thing we've done for it is reserve its protocol code in the table.
Add /dnsaddrand make it a "resolvable" protocol. You will encounter /dnsaddr addresses and it'd be good to regard them as valid.
I see that Multiaddr.resolve() doesn't really do anything yet. Maybe go-multiaddr-dns can serve as inspiration.
@lgierth I'm not understanding what is the real difference between /dns and /dnsaddr other than it seems that go-ipfs shipped /dnsaddr in the latest version, although it was not present on the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming /dns to /dnsaddr to conform with go